Skip to content

Run pre-commit without the Node 20 pre-commit action - #106

Open
yemine0x01 wants to merge 1 commit into
gridfm:mainfrom
yemine0x01:run-pre-commit-directly
Open

yemine0x01 wants to merge 1 commit into
gridfm:mainfrom
yemine0x01:run-pre-commit-directly

Conversation

@yemine0x01

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: yemine0x01 <youssouf.emine@artelys.com>
@romeokienzler

Copy link
Copy Markdown
Collaborator

@yemine0x01 thanks for tackling the Node 20 pre-commit action deprecation — this is a clean, focused fix.

What's needed

  • Looks good overall: the new pre-commit-run job is already passing on CI, which validates the swap away from pre-commit/action@v3.0.1, and the cache key on .pre-commit-config.yaml is sensible.
  • Just wait for pytests / dynamic-pytests to go green — they're still pending (and are unrelated to this workflow-only change, so no action expected on your end unless one fails).
  • Process nudge, per CONTRIBUTING: add Alban Puech as a reviewer.

No code/test/docs changes apply here since this is a CI workflow tweak. I'll defer the merge call to a maintainer.

— 🤖 _automated pre-review; a maintainer will follow up_

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants